Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serviceRole and instanceProfile to ClusterOptions #159

Merged
merged 11 commits into from
Jul 1, 2019
Merged

Add serviceRole and instanceProfile to ClusterOptions #159

merged 11 commits into from
Jul 1, 2019

Commits on Jun 12, 2019

  1. add serviceRole and instanceProfile to ClusterOptions

    @VRanga000
    VRanga000 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    82848f1 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @VRanga000
    VRanga000 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    3b514be View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Merge branch 'master' into feature/issue-158

    @VRanga000
    VRanga000 committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    ef8fd6c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. clarify inline documentation 

    Co-Authored-By: metral <1112768+metral@users.noreply.github.com>
    @VRanga000 @metral
    VRanga000 and metral authored Jun 18, 2019
    Configuration menu
    Copy the full SHA
    67288ea View commit details
    Browse the repository at this point in the history

  2. clarify inline documentation 

    Co-Authored-By: metral <1112768+metral@users.noreply.github.com>
    @VRanga000 @metral
    VRanga000 and metral authored Jun 18, 2019
    Configuration menu
    Copy the full SHA
    b9127f0 View commit details
    Browse the repository at this point in the history

  3. fix whitespace in comments, remove old doc lines

    @VRanga000
    VRanga000 committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    2495e4b View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. use more explicit typing for instanceProfileName 

    Co-Authored-By: Pat Gavlin <pgavlin@gmail.com>
    @VRanga000 @pgavlin
    VRanga000 and pgavlin authored Jun 21, 2019
    Configuration menu
    Copy the full SHA
    a0c61ab View commit details
    Browse the repository at this point in the history

  2. Update nodejs/eks/cluster.ts 

    Co-Authored-By: Pat Gavlin <pgavlin@gmail.com>
    @VRanga000 @pgavlin
    VRanga000 and pgavlin authored Jun 21, 2019
    Configuration menu
    Copy the full SHA
    d060515 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/issue-158

    @VRanga000
    VRanga000 authored Jun 21, 2019
    Configuration menu
    Copy the full SHA
    10c7079 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. fix syntax error

    @VRanga000
    VRanga000 committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    01da3f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. address review comments from @lukehoban - make other code branches un… 

    …iform in handling of instanceprofile creation
    @VRanga000
    VRanga000 committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    43248e5 View commit details
    Browse the repository at this point in the history