Fix js-yaml dependency changes in pulumi/k8s #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
added
the
impact/no-changelog-required
lblackstone
approved these changes
Feb 7, 2020
lblackstone
reviewed
Feb 7, 2020
metral
force-pushed
the
metral/fix-js-yaml
branch
from
74c3a2b
to
0513bfc
Compare
lblackstone
approved these changes
Feb 12, 2020
metral
force-pushed
the
metral/fix-js-yaml
branch
from
c925c7c
to
6907366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pulumi/eksafter it was removed frompulumi/k8swithUpdatetests to cut a new pulumi/eks release. These tests uselatestof pulumi/eks, which depended on pulumi/k8s for js-yaml, so they will always fail until we cut a new release of eks that does vendor it.Fixes #325