Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of js-yaml and YAML invoke changes in pulumi/k8s breaks withUpdate tests, and tests that load YAML #325

Closed
metral opened this issue Feb 8, 2020 · 2 comments · Fixed by #324
Assignees
Milestone

Comments

@metral
Copy link
Contributor

metral commented Feb 8, 2020

Problem description

withUpdate tests, and examples that load yaml (e.g. examples/clusters and examples/tests/replace-secgroup which deploy the YAML dashboard) are failing.

The withUpdate tests can't find the js-yaml module using the latest pulumi/eks release (0.18.19), as the latest release of pulumi/k8s (1.5.1) no longer vendors it, and pulumi/eks did not specifically vendor it:

Error: Cannot find module 'js-yaml'

The examples that load YAML through the dashboard hit the following error possibly due to changes in yamlLoadAll in the commit ref below:

[ xamples/tests/replace-secgroup ]     TypeError: Cannot read property 'map' of undefined
[ xamples/tests/replace-secgroup ]         at config.objs.then.configObjs (/opt/pulumi/node_modules/@pulumi/eks/node_modules/@pulumi/kubernetes/yaml/yaml.js:180:14

Errors & Logs

Travis CI Run Logs

Ref: pulumi/k8s commit where js-yaml was removed, and in the same commit where invoke yamlLoadAll changed.

@metral metral changed the title Removal of js-yaml from pulumi/k8s breaks withUpdate tests, and tests that load YAML Removal of js-yaml and YAML invoke changes in pulumi/k8s breaks withUpdate tests, and tests that load YAML Feb 8, 2020
@lblackstone
Copy link
Member

I expect this to be fixed by pulumi/pulumi-kubernetes#987

@metral
Copy link
Contributor Author

metral commented Feb 11, 2020

@metral metral added this to the 0.32 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants