Fix issue in OIDC getThumbprint helper function #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyers
changed the title
timmyers
force-pushed
the
tls-fingerprint-race
branch
from
2ede1ac
to
883c043
Compare
metral
approved these changes
Mar 11, 2020
metral
suggested changes
Mar 11, 2020
|
Woops totally missed the existing headers. |
timmyers
force-pushed
the
tls-fingerprint-race
branch
from
883c043
to
27f6463
Compare
timmyers
force-pushed
the
tls-fingerprint-race
branch
from
27f6463
to
5711f35
Compare
metral
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes an issue in the OIDC provisioning
getThumbprinthelper function. It is possible for HTTPS sessions to be cached between calls to this. When this happens, the SSL cert is not available. Allow no caching so we can always get the cert.This probably only caused issues when multiple clusters were in the stack.
Related issues
Fixes #345