deps(pulumi): bump node and go pulumi/pulumi to v1.13.1 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
metral/bump-pulumi-1.13.1
branch
from
12f4d75
to
0941225
Compare
lblackstone
approved these changes
Mar 30, 2020
EvanBoyle
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
One comment, otherwise looks good.
A question I have for you, did any of the code you're importing from pulumi/pulumi move? Some of the code from github.com/pulumi/pulumi/pkg moved into /sdk/go/common. Might just be worth verifying. Otherwise, it can cause sets of conflicting dependencies being brought in. If the build is passing, it is probably fine.
metral
force-pushed
the
metral/bump-pulumi-1.13.1
branch
from
0941225
to
f51c88f
Compare
|
Feedback has been addressed. PTAL @EvanBoyle |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump node and go pulumi/pulumi to v1.13.1
See:
Related issues (optional)
Closes #360