NodeGroups accept strings as InstanceTypes #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stanceType enum can be out of date
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1518351683 |
leezen
approved these changes
Nov 30, 2021
|
Thanks for fixing! |
leezen
changed the title
|
@leezen thanks for merging! :D |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The instance type parameter to NodeGroups should accept strings, in addition to the InstanceType enum, because the enum could be out of date. This is similar to what the EC2 object itself accepts in Pulumi.