Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix delegation not working #646

Merged

Conversation

JustinTW
Copy link
Contributor

Proposed changes

fix typo cause ENABLE_PREFIX_DELEGATION not working

Related issues (optional)

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@JustinTW JustinTW force-pushed the fix/fix-enable-prefix-delegation-typo branch from 7c1d502 to d2f689b Compare December 22, 2021 14:44
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@JustinTW JustinTW changed the title fix: fix typo cause ENABLE_PREFIX_DELEGATION not working fix: fix typo causing ENABLE_PREFIX_DELEGATION not working Dec 23, 2021
@JustinTW JustinTW changed the title fix: fix typo causing ENABLE_PREFIX_DELEGATION not working fix: fix enable prefix delegation not working Dec 23, 2021
@JustinTW JustinTW changed the title fix: fix enable prefix delegation not working fix: fix prefix delegation not working Dec 23, 2021
@JustinTW JustinTW changed the title fix: fix prefix delegation not working fix prefix delegation not working Dec 23, 2021
@JustinTW JustinTW changed the title fix prefix delegation not working Fix prefix delegation not working Dec 23, 2021
@JustinTW
Copy link
Contributor Author

JustinTW commented Dec 30, 2021

/ping @lblackstone @viveklak

@viveklak viveklak self-requested a review December 30, 2021 03:29
Copy link
Contributor

@viveklak viveklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1654540285

@lblackstone lblackstone merged commit 9c7c064 into pulumi:master Jan 4, 2022
@JustinTW JustinTW deleted the fix/fix-enable-prefix-delegation-typo branch January 6, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants