Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.21, Go and .NET versions in CI #937

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Nov 29, 2023

@mikhailshilkov mikhailshilkov added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 29, 2023
@mikhailshilkov mikhailshilkov changed the title Update Go and .NET versions in CI Update Go to 1.21, Go and .NET versions in CI Nov 29, 2023
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9251e92) 19.07% compared to head (cb73fa9) 19.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #937      +/-   ##
==========================================
+ Coverage   19.07%   19.84%   +0.77%     
==========================================
  Files          21       19       -2     
  Lines        5081     4882     -199     
==========================================
  Hits          969      969              
+ Misses       4029     3830     -199     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible. We should also upgrade the go.mod in examples too (which is currently 1.16).

@mikhailshilkov mikhailshilkov merged commit a2b91b3 into master Nov 29, 2023
17 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/go-version branch November 29, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants