Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen should escape resource methods only on resource classes #787

Closed
Tracked by #598
pawelprazak opened this issue Aug 11, 2022 · 1 comment · Fixed by #789
Closed
Tracked by #598

Codegen should escape resource methods only on resource classes #787

pawelprazak opened this issue Aug 11, 2022 · 1 comment · Fixed by #789
Assignees
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@pawelprazak
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently every getter and setter is escaped to avoid collision with methods inherited from Resource class family, but should only apply to the Resource child classes, not all classes.

This is the current entry point to the escape logic:
image

Found during this PR: #766

Ideas for a clean implementation that would differentiate between resource and non-resource classes very much welcome :)

Affected area/feature

@pawelprazak pawelprazak added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 11, 2022
@pawelprazak pawelprazak self-assigned this Aug 11, 2022
@t0yv0 t0yv0 added impact/breaking Fixing this issue will require a breaking change and removed needs-triage Needs attention from the triage team labels Aug 11, 2022
@t0yv0
Copy link
Member

t0yv0 commented Aug 11, 2022

Labelling as breaking, so we need to turn this around before GA. Thank you!

@t0yv0 t0yv0 added this to the 0.76 milestone Aug 11, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 12, 2022
@t0yv0 t0yv0 mentioned this issue Aug 16, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants