Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Escape javadoc special characters" V2 #1356

Merged
merged 2 commits into from
May 3, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented May 1, 2024

Reverts #1345

Fixes #1271

@iwahbe iwahbe self-assigned this May 1, 2024
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 1, 2024
@iwahbe iwahbe force-pushed the revert-1345-revert-1342-iwahbe/escape-javadoc-at branch from efd83c1 to 13c6850 Compare May 1, 2024 21:30
Unfortunately, it seems like the only way to get a non-escape inline comment is via
`{@snippet}` (introduced for Java 18). This PR implements a combined `{@code}` and
`<pre></pre>` strategy.
@iwahbe iwahbe force-pushed the revert-1345-revert-1342-iwahbe/escape-javadoc-at branch from 13c6850 to 55685fc Compare May 1, 2024 21:33
@iwahbe
Copy link
Member Author

iwahbe commented May 1, 2024

I have tested and confirmed that this works for pulumi-azure.

@iwahbe iwahbe requested review from t0yv0 and a team May 1, 2024 21:33
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy to review but looks reasonable.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick turnaround!

@iwahbe iwahbe merged commit c8db4b9 into main May 3, 2024
22 checks passed
@iwahbe iwahbe deleted the revert-1345-revert-1342-iwahbe/escape-javadoc-at branch May 3, 2024 19:38
EronWright added a commit to pulumi/pulumi-kubernetes that referenced this pull request May 24, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

This PR updates the pulumi-java dependency from v0.8.0 to v0.12.0.

Notable changes:
- pulumi/pulumi-java#1356
- pulumi/pulumi-java#1361
- pulumi/pulumi-java#1228

### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore or escape unintended javadoc comments
3 participants