-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Escape javadoc special characters" V2 #1356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc9c1ae.
iwahbe
added
the
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
label
May 1, 2024
iwahbe
force-pushed
the
revert-1345-revert-1342-iwahbe/escape-javadoc-at
branch
from
May 1, 2024 21:30
efd83c1
to
13c6850
Compare
iwahbe
force-pushed
the
revert-1345-revert-1342-iwahbe/escape-javadoc-at
branch
from
May 1, 2024 21:33
13c6850
to
55685fc
Compare
I have tested and confirmed that this works for pulumi-azure. |
thomas11
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not easy to review but looks reasonable.
t0yv0
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a quick turnaround!
EronWright
added a commit
to pulumi/pulumi-kubernetes
that referenced
this pull request
May 24, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes This PR updates the pulumi-java dependency from v0.8.0 to v0.12.0. Notable changes: - pulumi/pulumi-java#1356 - pulumi/pulumi-java#1361 - pulumi/pulumi-java#1228 ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1345
Fixes #1271