-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing Helm v3 Chart resource causes errors #2638
Labels
kind/bug
Some behavior is incorrect or out of spec
language/go
resolution/fixed
This issue was fixed
Milestone
Comments
scottslowe
added
kind/bug
Some behavior is incorrect or out of spec
needs-triage
Needs attention from the triage team
labels
Oct 25, 2023
We omit the namespace if it's pulumi-kubernetes/provider/pkg/gen/_go-templates/helm/v3/chart.go Lines 351 to 353 in f3498a9
We always need to include the namespace in generating the key. We should also double check the implementation for ConfigFile resources, and ensure it works as expected too! |
rquitales
added
language/go
and removed
needs-triage
Needs attention from the triage team
labels
Oct 25, 2023
rquitales
added a commit
that referenced
this issue
Dec 12, 2023
…mespace (#2655) ### Proposed changes This pull request modifies the `GetResource` Go method for the Helm Chart resource. Previously, when a resource was deployed to the default namespace, the `default` namespace was always omitted from the resource lookup key. However, in cases where the namespace is explicitly defined in the Helm chart template, the `default` namespace was inadvertently excluded from the resource lookup key despite it being needed. This behavior in Helm is documented in the upstream issue: helm/helm#3553. **Changes Made:** - Implemented a fallback mechanism to include the `default` namespace in the resource lookup key when necessary for the `GetResource` method. **Test Added:** - Added a test (`ChartGetResource`) to verify the `GetResource` method for both types of Helm charts—those with the explicitly defined default namespace and those without. **Verification:** - Verified that the modified `GetResource` method successfully handles scenarios where the namespace is explicitly defined in the Helm chart template. - Confirmed that the added test covers both types of Helm charts and fails when the fallback logic is reverted. ### Related issues (optional) Fixes: #2638
rquitales
added a commit
that referenced
this issue
Dec 15, 2023
…mespace (#2655) This pull request modifies the `GetResource` Go method for the Helm Chart resource. Previously, when a resource was deployed to the default namespace, the `default` namespace was always omitted from the resource lookup key. However, in cases where the namespace is explicitly defined in the Helm chart template, the `default` namespace was inadvertently excluded from the resource lookup key despite it being needed. This behavior in Helm is documented in the upstream issue: helm/helm#3553. **Changes Made:** - Implemented a fallback mechanism to include the `default` namespace in the resource lookup key when necessary for the `GetResource` method. **Test Added:** - Added a test (`ChartGetResource`) to verify the `GetResource` method for both types of Helm charts—those with the explicitly defined default namespace and those without. **Verification:** - Verified that the modified `GetResource` method successfully handles scenarios where the namespace is explicitly defined in the Helm chart template. - Confirmed that the added test covers both types of Helm charts and fails when the fallback logic is reverted. Fixes: #2638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/bug
Some behavior is incorrect or out of spec
language/go
resolution/fixed
This issue was fixed
What happened?
I was trying to use/update the
kubernetes-go-helm-wordpress
example with the Kubernetes v4 provider. I kept getting this error:Through additional testing, @rquitales verified that this is broken if the chart is installed into the "default" namespace, and is broken in preview for all namespaces.
Example
kubernetes-go-helm-wordpress
example with the Kubernetes v4 provider.pulumi up
. It should error during preview.Output of
pulumi about
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: