Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML support for Go SDK #1093

Merged
merged 27 commits into from
May 7, 2020
Merged

Add YAML support for Go SDK #1093

merged 27 commits into from
May 7, 2020

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented May 1, 2020

Proposed changes

Add initial YAML support including ConfigFile and ConfigGroup

TODO:

Related issues (optional)

Partial fix for #1037

provider/pkg/gen/go-templates/configFile.go Outdated Show resolved Hide resolved
provider/pkg/gen/go-templates/configFile.go Outdated Show resolved Hide resolved
provider/pkg/gen/go-templates/configFile.go Outdated Show resolved Hide resolved
provider/pkg/gen/go-templates/configGroup.go Outdated Show resolved Hide resolved
provider/pkg/gen/go-templates/configGroup.go Outdated Show resolved Hide resolved
provider/pkg/gen/go-templates/configGroup.go Outdated Show resolved Hide resolved
@lblackstone lblackstone marked this pull request as ready for review May 6, 2020 20:15
@lblackstone
Copy link
Member Author

Why is this ToOutput needed?

And relatedly - why does parseYamlObjects need to return a MapOutput?

You're right. I was able to cut all of those Outputs out and dramatically simplify things. I'll push the update shortly.

# Conflicts:
#	tests/integration/go/go_test.go
@lblackstone lblackstone requested a review from lukehoban May 6, 2020 22:34
provider/pkg/gen/go-templates/yaml/configGroup.tmpl Outdated Show resolved Hide resolved
tests/integration/go/yaml/main.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants