Add enums to the schema #1408
Merged
Add enums to the schema #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
force-pushed
the
komalali/latest-codegen
branch
5 times, most recently
from
014c37b
to
7e46ace
Compare
komalali
force-pushed
the
komalali/example-enum-pr
branch
from
3844913
to
e7abf3f
Compare
lblackstone
approved these changes
Dec 16, 2020
komalali
force-pushed
the
komalali/example-enum-pr
branch
from
b1a20bc
to
eaf39fa
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds an enum for
kubernetes.core.v1.ServiceSpec.Typecalledkubernetes.core.v1.ServiceSpecType.The first commit adds the enum type to
overlays.go, and assigns the enum to a property onkubernetes.core.v1.ServiceSpec. The second commit is the result of runningmake build.Related issues (optional)