Update pulumi deps #1588
Merged
Update pulumi deps #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Codegen change from pulumi/pulumi#7128 and remove hardcoded templates for v1/Secret resources - Nondeterministic import ordering fix from pulumi/pulumi#7126
lblackstone
force-pushed
the
lblackstone/update-codegen
branch
from
5961612
to
7bf7186
Compare
t0yv0
reviewed
May 26, 2021
| @@ -358,6 +311,45 @@ | |||
| "kubernetes:coordination.k8s.io/v1beta1:LeaseList": "LeaseList" | |||
| } | |||
| }, | |||
| { | |||
| "pkg": "kubernetes", | |||
| "mod": "core/v1", | |||
There was a problem hiding this comment.
This seems to be the ordering issue I pinged you about. It's now alpha sorted on "$pkg:$mod".
t0yv0
approved these changes
May 26, 2021
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
May 26, 2021
|
Test flake. Merging. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
and remove hardcoded templates for v1/Secret resources
getSecretinstead ofgetpulumi#7126Related issues (optional)
Related to #1577