-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: infer default namespace unless provided by provider config #1896
fix: infer default namespace unless provided by provider config #1896
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
fbb5e07
to
ec56538
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
ec56538
to
eb80ea9
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
@viveklak OK, I spent some time this morning going through this code properly and I understand the problem now. I've updated the PR. I have no idea how to write a unit test for the Setup:
Test 1:
Test 2:
I believe this is the behaviour that we need to resolve #971 cc @lblackstone |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
1 similar comment
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/1790575272 |
Proposed changes
Use the discovered kubeconfig namespace when one isn't provided by the Provider configuration instead of default.
Related issues (optional)
Fix #971