Fix fetching remote yaml files #1962
Conversation
afreakk
changed the title
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2196909279 |
|
Thanks for the PR @afreakk! This file is actually auto generated. Could you make the change to https://github.com/pulumi/pulumi-kubernetes/blob/master/provider/pkg/gen/_go-templates/yaml/yaml.tmpl#L48 instead and then run a |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
@viveklak ok, force pushed updated commit with change only to the tpl file |
I expect the CI to fail run to fail since we also expect the generated code checked in. Could you retain the change in the "generated" file and submit that along side the the template file? Alternatively my suggestion to run a make build would perform the generation for you and you could check the results in. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
I ran |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2198207777 |
|
Thanks @afreakk for the fix! |
Proposed changes
Currently it only treats the filepath as a url if the path fails to parse as url.
Related issues (optional)
#1851