-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yaml bug resulting in TypeError: Cannot read properties of undefined
#2156
Conversation
TypeError: Cannot read properties of undefined
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix LGTM
@lblackstone this is ready for another review. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
I see this poping up again
|
Same for me
|
@LucasBrazi06 Could you please open a new issue for that? I want to make sure we don't lose track of this. |
Proposed changes
Fixes #2038 for typescript.
Fixes #1987 for python.
As discussed on the issue, calling an invoke on an unconfigured provider results in the invoke never reaching the provider. This fixes a halting error here but it will not return the correct preview if things like kubeconfig are missing in the provider.
Related issues (optional)
#2038