Fix StatefulSet await logic for OnDelete update #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The await logic for StatefulSets previously only worked for the default RollingUpdate strategy. StatefulSets that were updated using the OnDelete strategy would incorrectly report that they were not ready because the provider was not accounting for differences in the status fields that depend on the update method. This change fixes the await logic so that both update strategies correctly report readiness.
|
I confirmed that the new test fails before the change, and passes after. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The await logic for StatefulSets previously only worked for the default RollingUpdate strategy. StatefulSets that were updated using the OnDelete strategy would incorrectly report that they were not ready because the provider was not accounting for differences in the status fields that depend on the update method. This change fixes the await logic so that both update strategies correctly report readiness.
Related issues (optional)
Fix #1066