Improve deleteUnreachable workflow #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider includes a deleteUnreachable option that will delete unreachable cluster resources from state. This was added as an opt-in behavior to avoid accidental state deletion for a temporarily unreachable cluster. This change improves this workflow in two ways: 1. The error messages for both the refresh and destroy cases were revised for clarity, and suggest using the PULUMI_K8S_DELETE_UNREACHABLE environment variable to enable this behavior. 2. The destroy workflow was changed to succeed for unreachable resources when the deleteUnreachable option is set rather than requiring the user to refresh the state as a separate step. Note that this behavior can also be enabled with the Provider's deleteUnreachable configuration, but we do not mention this in the error message since it could lead to undesired state changes in case of a temporarily unreachable cluster.
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
approved these changes
Jul 11, 2023
This was referenced Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The provider includes a deleteUnreachable option that will delete unreachable cluster resources from state. This was added as an opt-in behavior to avoid accidental state deletion for a temporarily unreachable cluster. This change improves this workflow in two ways:
Note that this behavior can also be enabled with the Provider's deleteUnreachable configuration, but we do not mention this in the error message since it could lead to undesired state changes in case of a temporarily unreachable cluster.
Related issues (optional)
Fix #2463