Propagate cancellation to Helm Release provider action #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EronWright
commented
Sep 26, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
approved these changes
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #2579 +/- ##
==========================================
- Coverage 18.73% 18.52% -0.22%
==========================================
Files 47 47
Lines 9532 9534 +2
==========================================
- Hits 1786 1766 -20
- Misses 7642 7669 +27
+ Partials 104 99 -5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #2485.
This PR implements cancelation for
CreateandUpdateoperations on the Helm Release resource. When the user presses ctrl-c, the Helm operation is cancelled and the stack state is updated accordingly. This is an improvement over the current behavior where the Helm release may be orphaned by Pulumi.A future enhancement would be to implement cancelation for the
Deleteoperation, once it becomes possible in the Helm v3 library (see PR and theRunWithContextvariants).Note: no new tests are provided because I don't see a way to simulate cancelation using the integration test framework.
Related issues (optional)
Related to pulumi/pulumi#14057. It is safe to merge this PR beforehand.