Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes client dependencies to v0.28.2 #2585

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

rquitales
Copy link
Member

@rquitales rquitales commented Sep 29, 2023

Proposed changes

Upgrade client libraries to v0.28.2 to pull in latest API types for Kubernetes v1.28. A follow-up to #2526.

  • Ran go get -u k8s.io/* in /providers and /tests to upgrade client libraries
  • Ran go mod tidy
  • Update github.com/google/gnostic import to github.com/google/gnostic-models to satisfy function/interface signature changes.

Unit tests passes locally as well.

Related issues (optional)

Fixes: #2583

Run `go get -u k8s.io/*` in /providers and /tests to upgrade client libraries

Run `go mod tidy`

Update github.com/google/gnostic import to github.com/google/gnostic-models to satisfy function/interface signatures.
@rquitales rquitales changed the title Upgrade all k8s client libraries Upgrade Kubernetes client dependencies to v0.28.2 Sep 29, 2023
@rquitales rquitales requested review from EronWright and a team September 29, 2023 22:35
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #2585 (e0df14e) into master (7a84ace) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2585      +/-   ##
==========================================
- Coverage   18.73%   18.52%   -0.21%     
==========================================
  Files          47       47              
  Lines        9534     9534              
==========================================
- Hits         1786     1766      -20     
- Misses       7644     7669      +25     
+ Partials      104       99       -5     
Files Coverage Δ
provider/pkg/clients/memcache.go 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rquitales rquitales merged commit 98306fc into master Oct 2, 2023
18 checks passed
@rquitales rquitales deleted the rquitales/fix-initcontainers branch October 2, 2023 17:52
@EronWright
Copy link
Contributor

EronWright commented Oct 2, 2023

@rquitales do we have a playbook for this procedure, and if not could you write one?
Do we need to update await code for deprecations, as shown here? #2441

@EronWright EronWright added the dependencies Pull requests that update a dependency file label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SidecarContainers: not able to set restartPolicy: 'Always' on initContainers
4 participants