skip normalization in preview w/ computed fields #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2846 +/- ##
=======================================
Coverage 25.48% 25.48%
=======================================
Files 48 48
Lines 7526 7526
=======================================
Hits 1918 1918
Misses 5450 5450
Partials 158 158 ☔ View full report in Codecov by Sentry. |
rquitales
approved these changes
Feb 26, 2024
EronWright
force-pushed
the
eronwright/issue-2845
branch
from
696357f
to
d0d0480
Compare
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Feb 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/kubernetes](https://pulumi.com) ([source](https://togithub.com/pulumi/pulumi-kubernetes)) | dependencies | patch | [`4.8.0` -> `4.8.1`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.8.0/4.8.1) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-kubernetes (@​pulumi/kubernetes)</summary> ### [`v4.8.1`](https://togithub.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#481-February-22-2024) [Compare Source](https://togithub.com/pulumi/pulumi-kubernetes/compare/v4.8.0...v4.8.1) - skip normalization in preview w/ computed fields ([https://github.com/pulumi/pulumi-kubernetes/pull/2846](https://togithub.com/pulumi/pulumi-kubernetes/pull/2846)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIxNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Skips the normalization step in the presence of computed inputs.
Note: previously when
clients.Normalizewas called with aSecret, it would panic. If called with a non-secret, an internal error would be masked and the original object would be used.Related issues (optional)
Closes #2845