Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate python casing table #387

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Autogenerate python casing table #387

merged 4 commits into from
Feb 1, 2019

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jan 31, 2019 •
edited
Loading

Fixes #258

@lblackstone lblackstone changed the title WIP: Autogenerate python casing table Autogenerate python casing table Jan 31, 2019
hausdorff
hausdorff approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one non-blocking suggestion, and great embarrassment that we are currently missing properties.

pkg/gen/typegen.go Show resolved Hide resolved
@lblackstone
Copy link
Member Author

The capitalized words included in the latest update seem to be causing problems. Specifically the Port: port mapping is causing test failures. I'm going to switch back to camelCase words only, and we can reevaluate if it causes problems later.

@lblackstone lblackstone merged commit 1979021 into master Feb 1, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/casing-table-python branch February 1, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hausdorff hausdorff hausdorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lblackstone @hausdorff