Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt changes to Read and Diff #477

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Adopt changes to Read and Diff #477

merged 3 commits into from
Jun 26, 2019

Commits on Jun 24, 2019

  1. Adopt changes to Read and Diff

    1. Return resource inputs as well as resource state from Read()
    2. Return a list of properties that changed from Diff()
    
    We implement the former by reading the last applied configuration
    from the `kubectl.kubernetes.io/last-applied-configuration`
    annotation in the live object state. If this key is not present, no
    inputs are populated and the old inputs are retained. These changes
    also update the provider to set this field during `Create` and
    `Update`.
    
    We implement the latter by scanning the JSON diff and recording the
    names of the top-level properties that changed. The engine uses this
    information to filter diffs to only those that are semantically
    meaningful.
    
    These changes required a couple of bugfixes:
    - Old names are only adopted if the old resource was auto-named. This
      ensures that a name must be specified when importing a resource that
      was not autonamed.
    - URN to GVK conversion was fixed for resources in the "core" group.
      These resources have no group part in the GVK. Parsing was also
      simplified through the use of pulumi/pulumi's token manipulation
      functions.
    - When reading a resource, the GVK for the resource to read is now
      pulled from the URN if it is absent from the inputs.
    pgavlin committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d4f44c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Fix the CHANGELOG

    pgavlin committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0b90143 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    180f4b1 View commit details
    Browse the repository at this point in the history