Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigGroup does not load urls #448

Closed
adaniline-traderev opened this issue Feb 22, 2019 · 2 comments · Fixed by #638
Closed

ConfigGroup does not load urls #448

adaniline-traderev opened this issue Feb 22, 2019 · 2 comments · Fixed by #638
Assignees
Labels
area/yaml impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@adaniline-traderev
Copy link

This should be implemented, according to #150, but when I try to load several yamls by url with ConfigGroup, it does not work. ConfigFile works:

new k8s.yaml.ConfigGroup("jenkins-operator", {
    files: [
        'https://raw.githubusercontent.com/VirtusLab/jenkins-operator/master/deploy/crds/virtuslab_v1alpha1_jenkins_crd.yaml',
        'https://raw.githubusercontent.com/VirtusLab/jenkins-operator/master/deploy/service_account.yaml',
        'https://raw.githubusercontent.com/VirtusLab/jenkins-operator/master/deploy/role.yaml',
        'https://raw.githubusercontent.com/VirtusLab/jenkins-operator/master/deploy/role_binding.yaml',
        'https://raw.githubusercontent.com/VirtusLab/jenkins-operator/master/deploy/operator.yaml',
    ],
    transformations: [
        (obj => obj.metadata.namespace = namespace)
    ]
}, {
    providers: {
        kubernetes: k8sProvider
    }
});
@lblackstone lblackstone added impact/usability Something that impacts users' ability to use the product easily and intuitively kind/feature area/yaml labels Feb 25, 2019
@lblackstone
Copy link
Member

I took a look at this, and it seems that the URL support wasn't actually implemented for ConfigGroup in #150. Until this gets fixed, you can still load them with ConfigFile.

@joeduffy joeduffy added this to the 0.22 milestone Mar 7, 2019
@lblackstone lblackstone removed this from the 0.22 milestone Apr 8, 2019
@hausdorff
Copy link
Contributor

I'm skeptical this needs to go into Q3, but it's also small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yaml impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants