Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace arg for Python Helm SDK #670

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Fix namespace arg for Python Helm SDK #670

merged 2 commits into from
Aug 2, 2019

Conversation

lblackstone
Copy link
Member

Fixes #562

@lblackstone lblackstone force-pushed the lblackstone/python-helm-namespace branch from 0b8fd8d to efd16fd Compare July 30, 2019 20:06
@lblackstone lblackstone changed the title WIP: fix namespace Fix namespace arg for Python Helm SDK Jul 30, 2019
@lblackstone lblackstone marked this pull request as ready for review July 30, 2019 20:08
@lblackstone lblackstone force-pushed the lblackstone/python-helm-namespace branch from b09d8a9 to 9734a71 Compare July 31, 2019 19:16
@lblackstone lblackstone mentioned this pull request Aug 1, 2019
Merged
@lblackstone lblackstone force-pushed the lblackstone/python-helm-namespace branch from 8600d0e to e3e20c8 Compare August 2, 2019 15:19
@lblackstone
Fix namespace arg for Python Helm SDK
9c0b6a9 
Previously, this code was not unwrapping the Output properly
for dynamic namespace names. The async logic used to
unwrap the namespace wasn't playing nicely with the
NamedTemporaryFile and TemporaryDirectory context
managers, so switch to using the lower-level APIs instead
and manually clean up those resources when done.
@lblackstone
Update comment
c13ebbb
@lblackstone lblackstone force-pushed the lblackstone/python-helm-namespace branch from e3e20c8 to c13ebbb Compare August 2, 2019 19:05
@lblackstone lblackstone merged commit 5d63b85 into master Aug 2, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/python-helm-namespace branch August 2, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hausdorff hausdorff hausdorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Helm SDK not handling namespace arg properly
2 participants
@lblackstone @hausdorff