Add PodAggregator for use by resource awaiters #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/pod-aggregator
branch
from
c351f37
to
5b8c400
Compare
lblackstone
force-pushed
the
lblackstone/pod-aggregator
branch
2 times, most recently
from
d711a28
to
a9cc558
Compare
The PodAggregator encapsulates the logic required to aggregate warning/error messages from Pods related to a parent resource such as a Deployment or Job. This will make it easier to collect relevant intermediate status in a consistent way.
lblackstone
force-pushed
the
lblackstone/pod-aggregator
branch
from
a9cc558
to
f2938a8
Compare
metral
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The PodAggregator encapsulates the logic required to aggregate
warning/error messages from Pods related to a parent resource
such as a Deployment or Job. This will make it easier to collect
relevant intermediate status in a consistent way.
Related issues (optional)