This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Add support for metada in createService method #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also uses deployment metadata name as service name by default rather than the deployment resource id
| return new Service(String(metadata?.name) ?? this.name, { | ||
| metadata: { | ||
| namespace: this.metadata.namespace, | ||
| name: metadata?.name ?? this.metadata.name, |
There was a problem hiding this comment.
By setting the name here with a default, how will this impact existing users of the library?
|
Following an internal conversation, we might not be able to release this immeidately as this component isn't actively supported - meaning some of the release mechanism requires additional updates which we've not got capacity to replace. But if you're happy to leave this open then we'll endevour to incorporate this change at the point we can invest more into this component. Thanks again for the contribution here, sorry we can't get this shipped out as fast as we'd like. |
|
Due to lack of tests in this repo and the age, we're not in a good position to move this PR forward so closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
createServicemethod on Deployment class uses deployment name with randomised suffix by default and has no means of defining custom name or namespace for a service. Of course, this can be done with thekx.Serviceclass but it would be nice to provide overriding options increateServicemethod.This also uses deployment metadata name as service name by default rather than the deployment resource id which provides some stability.
This closes #52 and #73