Upgrade terraform-provider-nomad to v2.1.0

[pulumi-bot]

Release details: https://github.com/hashicorp/terraform-provider-nomad/releases/tag/v2.1.0

[iwahbe]

This version contains BUSL code: github.com/hashicorp/nomad/helper/pointer.

[kevinschoonover]

This version contains BUSL code: github.com/hashicorp/nomad/helper/pointer.

@iwahbe I was looking around the repo, but don't see any indication its importing this package. It looks like its bundling its own and tagged it as MPL-2.0. I was looking in their FAQ and they also mention their terraform providers remain MPL-2.0

I admittedly don't understand the finer points of licensing, but this release includes new constructs (such as crons) which I use for my jobs

[iwahbe]

Hi @kevinschoonover. Sorry for not getting back to you sooner. This is my understanding:

Hashi's BUSL license is infectious (transitive), so any code that depends on BUSL code is in fact BUSL. This is like a copyleft licenses.

The terraform-nomad-provider (which pulumi-nomad wraps) imports github.com/hashicorp/nomad/jobspec (src). Ideally, that would be fine, since github.com/hashicorp/nomad/jobspec is explicitly licensed as MPL 2.0... however, github.com/hashicorp/nomad/jobspec imports github.com/hashicorp/nomad/helper/pointer (src). github.com/hashicorp/nomad/helper/pointer is licensed at the repo root, and thus BUSL.

That means that github.com/hashicorp/nomad/jobspec and thus github.com/hashicorp/terraform-nomad-provider can be argued to be BUSL. The license is unclear.

We are not willing to assume liability on an ambiguous license. We can upgrade again if github.com/hashicorp/nomad/jobspec removes their trivial dependency on github.com/hashicorp/nomad/helper/pointer or if Hashi drops an OSS LICENSE file in the path of github.com/hashicorp/nomad/helper/pointer (like they have for github.com/hashicorp/nomad/jobspec).

[kevinschoonover]

Hey @iwahbe, the nomad folks should now be tracking this in hashicorp/nomad#19832. Putting it here for reference.

There is an initial PR which should unblock this hashicorp/nomad#19832 when merged.

[iwahbe]

@kevinschoonover That is awesome!