chore: better type checking error messages #1997
Merged
+171
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what the error message looks like
```console
aws:ecs:Service (service):
warning: Type checking failed:
Unexpected type at field networkConfiguration.subnets:
expected array type, got string type
warning: Type checking is still experimental. If you believe that a warning is incorrect,
please let us know by creating an issue at https://github.com/pulumi/pulumi-terraform-bridge/issues.
This will become a hard error in the future.
```
fixes #1986
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
+ Coverage 60.87% 60.90% +0.03%
==========================================
Files 332 332
Lines 44756 44761 +5
==========================================
+ Hits 27243 27260 +17
+ Misses 15990 15978 -12
Partials 1523 1523 ☔ View full report in Codecov by Sentry. |
iwahbe
reviewed
May 20, 2024
Co-authored-by: Ian Wahbe <ian@wahbe.com>
corymhall
commented
May 21, 2024
|
|
||
| // run 'go test -run=TestCheckWarnings -v ./pkg/tfbridge/ -update' to update | ||
| autogold.Expect(`warning: Type checking failed: | ||
| warning: Unexpected type at field "networkConfiguration": |
There was a problem hiding this comment.
Each time you call logger.Warn() it prints out warning: . Personally I don't mind this.
iwahbe
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what the error message looks like
fixes #1986