Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF test defaults and plan modifiers #2217

Merged
merged 40 commits into from
Aug 21, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jul 21, 2024

Adds PF integration tests for defaults and plan modifiers.

Regression tests for #2171 and #2218

stacked on #2254

@VenelinMartinov VenelinMartinov changed the base branch from master to vvm/pf_tests_fixups July 21, 2024 13:17
Base automatically changed from vvm/pf_tests_fixups to master July 23, 2024 04:49
@VenelinMartinov VenelinMartinov marked this pull request as draft July 23, 2024 11:36
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.99%. Comparing base (87006ca) to head (bb3c4d0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
- Coverage   56.99%   56.99%   -0.01%     
==========================================
  Files         366      366              
  Lines       50096    50096              
==========================================
- Hits        28554    28552       -2     
- Misses      19974    19976       +2     
  Partials     1568     1568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov changed the base branch from master to vvm/pf_tf_integration_tests July 26, 2024 10:43
@VenelinMartinov VenelinMartinov changed the title PF defaults repro Test defaults and plan modifiers Jul 26, 2024
@VenelinMartinov VenelinMartinov changed the title Test defaults and plan modifiers PF test defaults and plan modifiers Jul 26, 2024
@VenelinMartinov VenelinMartinov mentioned this pull request Jul 26, 2024
@VenelinMartinov VenelinMartinov marked this pull request as ready for review July 30, 2024 09:12
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
Base automatically changed from vvm/pf_tf_integration_tests to master August 20, 2024 15:05
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) August 20, 2024 15:09
@mikhailshilkov mikhailshilkov modified the milestones: 0.108, 0.109 Aug 21, 2024
@VenelinMartinov VenelinMartinov merged commit c364b35 into master Aug 21, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_defaults_repro branch August 21, 2024 10:05
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants