Add GitHub Actions detection and update the Pulumi CI escape hatch with more CI vars #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneetloke
commented
Jun 5, 2020
| func (t githubActionsCI) DetectVars() Vars { | ||
| v := Vars{Name: GitHubActions} | ||
| v.BuildID = os.Getenv("GITHUB_RUN_ID") | ||
| v.BuildNumber = os.Getenv("GITHUB_RUN_NUMBER") |
There was a problem hiding this comment.
This is the human-friendly number to show in the UI:
praneetloke
commented
Jun 5, 2020
| // See https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables. | ||
| func (t githubActionsCI) DetectVars() Vars { | ||
| v := Vars{Name: GitHubActions} | ||
| v.BuildID = os.Getenv("GITHUB_RUN_ID") |
There was a problem hiding this comment.
This is the ID that goes in the URL. For example, https://github.com/pulumi/docs/actions/runs/126408154.
chrsmith
approved these changes
Jun 8, 2020
|
|
||
| // DetectVars detects the GitHub Actions env vars. | ||
| // nolint: lll | ||
| // See https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables. |
There was a problem hiding this comment.
Nit: We can probably trim off the #default-environment-variables. part.
praneetloke
force-pushed
the
praneetloke/github-actions-ci
branch
from
0bad44a
to
d4bd56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the detection logic for GitHub Actions. I have also updated our escape-hatch code for unknown CI systems to allow users to set all CI vars that we support today.
This PR might address the problem reported in #4613.