Add the ability to pulumi.unsecret an existing output #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
requested review from
justinvp and
komalali
and removed request for
justinvp
stack72
changed the title
|
After speaking with @lukehoban we are going to revert the changes to IsSecret and have a top level func 'isSecret' alongside 'unsecret' - this will ensure we don't break the backwards compatibility with old versions |
stack72
force-pushed
the
unsecret-nodejs
branch
from
ca0a3c6
to
43c44ca
Compare
komalali
approved these changes
Jan 12, 2021
stack72
force-pushed
the
unsecret-nodejs
branch
from
1b639fe
to
fe2d457
Compare
justinvp
reviewed
Jan 12, 2021
Related: #5653 This will take an existing output and then unwrap the secret, and return a new output ``` import * as pulumi from "@pulumi/pulumi"; const x = pulumi.secret("test") export const xVal = x; const y = pulumi.unsecret(x); export const yVal = y; ``` ``` ▶ pulumi stack output Current stack outputs (3): OUTPUT VALUE xVal [secret] yVal test ``` Also adds the ability to check if an output is as secret: ``` import * as pulumi from "@pulumi/pulumi"; const x = pulumi.secret("test") const isSecret = x.isSecret; export const isSecretDeets = isSecret; ```
stack72
force-pushed
the
unsecret-nodejs
branch
from
fe2d457
to
ae3ecde
Compare
|
So @justinvp and I had a call about this - we are going to leave these funcs as taking the Output itself for now - if we decide that needs to change in the future then we can do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5653
This will take an existing output and then unwrap the secret, and
return a new output
Also adds the ability to check if an output is as secret: