[sdk/nodejs] Support for calling methods #7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
justinvp
force-pushed
the
justin/methods_calling_nodejs
branch
from
eb6d244
to
6c836ad
Compare
EvanBoyle
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
overall these changes look good. runtime/* has been a been a bug farm and can fail in exciting ways so it would be good to see some tests that specifically exercise the call failure path if at all possible. We have some runtime register resource tests that do this:
pulumi/sdk/nodejs/tests/runtime/props.spec.ts
Line 361 in e955a6b
pgavlin
approved these changes
Jul 1, 2021
| @@ -101,27 +101,27 @@ export async function streamInvoke( | |||
| const req = createInvokeRequest(tok, serialized, provider, opts); | |||
|
|
|||
| // Call `streamInvoke`. | |||
| const call = monitor.streamInvoke(req, {}); | |||
There was a problem hiding this comment.
Did this change b/c of a lint issue w. shadowing?
`__provider` is already used by the dynamic provider `Resource` class, so we need to use another property name here.
justinvp
force-pushed
the
justin/methods_calling_nodejs
branch
from
6c836ad
to
1e300c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for calling methods from Node.js.
Part of #7072