[sdk/nodejs] Pickup provider as part of providers #8923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
approved these changes
Feb 3, 2022
| const depreciation = "This will become an error by the end of July 2022. See https://github.com/pulumi/pulumi/issues/8799 for more details"; | ||
| log.warn(message+depreciation); | ||
| } else { | ||
| (<ProviderResource[]> componentOpts.providers).push(componentOpts.provider); |
There was a problem hiding this comment.
Is componentOpts.providers guaranteed to be truthy here? I think we need to guard against that.
Suggested change
| (<ProviderResource[]> componentOpts.providers).push(componentOpts.provider); | |
| (<ProviderResource[]> componentOpts.providers)?.push(componentOpts.provider); |
There was a problem hiding this comment.
We do need to guard against it, but not by bailing out. In case of a providers === undefined, we should set providers = [provider]. a27708f makes that change.
Codecov Report
@@ Coverage Diff @@
## master #8923 +/- ##
=======================================
Coverage 59.39% 59.40%
=======================================
Files 642 642
Lines 99643 99665 +22
Branches 1389 1392 +3
=======================================
+ Hits 59185 59203 +18
+ Misses 37086 37083 -3
- Partials 3372 3379 +7
Continue to review full report at Codecov.
|
pulumi-bot
deleted the
iwahbe/8921/ts-correctly-pickup-provider-resource-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8921
Checklist