-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API Docs paths/structure #63
Conversation
Your site preview for commit 4d85db9 is ready! 🎉 http://registry-origin-pr-63-4d85db96.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 19b10ab is ready! 🎉 http://registry-origin-pr-63-19b10ab0.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 392f2bd is ready! 🎉 http://registry-origin-pr-63-392f2bd1.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 6a83889 is ready! 🎉 http://registry-origin-pr-63-6a838890.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 2fd4897 is ready! 🎉 http://registry-origin-pr-63-2fd4897f.s3-website.us-west-2.amazonaws.com. |
I'm not sure if it's just me, but looking at the latest preview link, when I click the API Docs tab on a package, nothing happens - the tab content doesn't load, the tab doesn't get active styles, etc. |
Yeah, the problem with this is that the API docs are generated in the |
Your site preview for commit ae7dec5 is ready! 🎉 http://registry-origin-pr-63-ae7dec5f.s3-website.us-west-2.amazonaws.com. |
@kimberleyamackenzie @djgrove yeah we definitely need to have another conversation about moving the API docs from the docs repo to this repo. It'll make a few things better. |
Hmm @djgrove as Kimberley said I expected to at least see that the active tab would change when I click on the API Docs tab but with no API docs in there because they are all in |
No, this is expected. The API Docs |
@djgrove that makes sense. I also noticed that you deleted the |
Site previews for this pull request have been removed. ✨ |
A few changes to support the docs being generated in a new location.
registry/packages/<package>/api.docs.md
as these files are now generated properly.