Add gomod-override #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomod-override is analagous to govendor-override, except it works on go.mod files used with Go 1.11 modules instead of govendor.json files. For now it has the following restrictions: - Only the first constraint in the template with `gomod-override = true` will be processed - Replace directives in the go.mod file are not honoured This is sufficient to build a solvable set of dependency constraints for the Google Cloud Beta provider, which was the initial aim. It's anticipated that further work will be required over time.
pgavlin
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gomod-overrideis analagous togovendor-override, except it works ongo.modfiles used with Go 1.11 modules instead ofgovendor.jsonfiles.For now it has the following restrictions:
gomod-override = truewill be processedThis is sufficient to build a solvable set of dependency constraints for the Google Cloud Beta provider, which was the initial aim. It's anticipated that further work will be required over time.
A large amount of the code for parsing
go.modfiles is copy/pasted from the Go source tree, where it is marked internal.