Strongish cipher suite with FS support for some browsers #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the dhparam be configurable? Eg. With 2048 Bit RSA keys it's recommended to use a 2048 dhparam. Alternatively, the code could embed multiple params and choose the size matching the key, but that would lead to incompatibility with java 6 which some users might care about. |
|
My goal here is to keep the "Need a bit of security? Use SSL sockets!" updated, I don't want to break anything nor set some requirements. |
|
Embedding DH params like this is a no-no. It needs to be pulled out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cipher Strength from 60 to 90