Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix an extra space in a sentence in gemspec description. #667

Merged
merged 1 commit into from
Mar 12, 2015
Merged

[ci skip] Fix an extra space in a sentence in gemspec description. #667

merged 1 commit into from
Mar 12, 2015

Conversation

JuanitoFatas
Copy link
Contributor

diff --git a/puma.gemspec b/puma.gemspec
index 9243cd6..4f3ce34 100644
--- a/puma.gemspec
+++ b/puma.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Evan Phoenix"]
   s.date = `git log --pretty="%ai" -n 1`.split(" ").first
-  s.description = "Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server for Ruby/Rack applications. Puma is intended for use in both development and production environments. In order to get the best throughput, it is highly recommended that you use a  Ruby implementation with real threads like Rubinius or JRuby."
+  s.description = "Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server for Ruby/Rack applications. Puma is intended for use in both development and production environments. In order to get the best throughput, it is highly recommended that you use a Ruby implementation with real threads like Rubinius or JRuby."
   s.email = ["evan@phx.io"]
   s.executables = ["puma", "pumactl"]
   s.extensions = ["ext/puma_http11/extconf.rb"]

Before

```
it is highly recommended that you use a  Ruby implementation with real threads like Rubinius or JRuby.
```

After

```
it is highly recommended that you use a Ruby implementation with real threads like Rubinius or JRuby.
```
@JuanitoFatas
Copy link
Contributor Author

P.S. Could you please also add some metadata information of this gem in this page https://rubygems.org/gems/puma/edit 🙏:

screenshot 2015-03-12 15 55 19

Here are some I know:

URL VALUE
Source Code URL https://github.com/puma/puma
Documentation URL http://www.rubydoc.info/gems/puma
Wiki URL https://github.com/puma/puma/wiki
Mailing List URL N/A
Bug Tracker URL https://github.com/puma/puma/issues

Thank you!

evanphx added a commit that referenced this pull request Mar 12, 2015
[ci skip] Fix an extra space in a sentence in gemspec description.
@evanphx evanphx merged commit f0de3cd into puma:master Mar 12, 2015
@evanphx
Copy link
Member

evanphx commented Mar 12, 2015

Done!

On Thu, Mar 12, 2015 at 12:54 AM, Juanito Fatas notifications@github.com
wrote:

P.S. Could you also add some metadata info in this page
https://rubygems.org/gems/puma/edit, please [image: 🙏]

Here are some I know:
URL VALUE Source Code URL https://github.com/puma/puma Documentation
URL
http://www.rubydoc.info/gems/puma Wiki URL
https://github.com/puma/puma/wiki Mailing List URL N/A Bug Tracker
URL
https://github.com/github/puma/issues


Reply to this email directly or view it on GitHub
#667 (comment).

@JuanitoFatas
Copy link
Contributor Author

Thank you so much, Mr Phoenix!!!!!! ❤️ 💛 💙 💚 💜

@JuanitoFatas JuanitoFatas deleted the doc/gemspec branch March 12, 2015 16:52
@evanphx
Copy link
Member

evanphx commented Mar 12, 2015

Thank you!! 😘😘😘

On Thu, Mar 12, 2015 at 9:52 AM, Juanito Fatas notifications@github.com
wrote:

Thank you so much, Mr Phoenix!!!!!! ❤️ 💛 💙 💚 💜

Reply to this email directly or view it on GitHub:
#667 (comment)

@JuanitoFatas
Copy link
Contributor Author

@evanphx Sorry I found bug tracker url is wrong:

"bug_tracker_uri"=>"https://github.com/github/puma/issues"

should be

"https://github.com/puma/puma/issues"

My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants