Add percentile averaging mode #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 93.39% 93.54% +0.14%
==========================================
Files 9 9
Lines 757 774 +17
==========================================
+ Hits 707 724 +17
Misses 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jmbhughes
reviewed
Apr 6, 2023
| # n.b. If mode is 'median', we could set mode='percentile' | ||
| # and percentile=50 to simplify parts of this function, but | ||
| # np.nanpercentile(x, 50) seems to be about half as fast as | ||
| # np.nanmedian(x), so let's keep a speedy special case for medians. |
There was a problem hiding this comment.
I wonder what optimizations they're doing to achieve that speedup.
jmbhughes
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "percentile" as an averaging mode.
As I was updating the tests, I noticed that for the "mean" averaging mode,
nanvalues are rejected by thenansum, but they're still counted in thecountsarray, which will mean pixels that havenans in some of the input patches will get a downward bias. I changedcountsto count the number of non-nan inputs per-pixel, rather than being a simple sum of the number of input patches, to address this.(This will cause a merge conflict for the visualization PR, as that one had also made changes to the
countsarray. Once one of these PRs is merged, I'll update the other, where there will probably end up being amean_countstracker of the number of non-nancontributions to each pixel for the average, and a separatecountstracker that just tracks the number of input patches to each combined patch.)