This repository was archived by the owner on Jun 9, 2023. It is now read-only.
"Don't autorequire git class" #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git class used to be part of this module but is no longer. Stop autorequiring it.
|
Hi, I made a pull request to resolve the dependency issues with ruby 1.8.7, but other errors appeared during the build. #13 What do you think about ruby 1.8.7 support removal? Everything works well with 1.9.3. |
|
Most of my infra is still on 1.8.7 so I'd like it to work on 1.8.7. This is a really simple resource so it should be solvable to make it work on 1.8.7 |
|
One of the deep-dependency simple dropped 1.8.7 support: https://github.com/bodeco/bodeco_module_helper using that. M. |
|
We don't need blacksmith for 1.8.7 that is a publishing dependency not a runtime dependecy. |
|
Ok, puppet-blacksmith downgraded too for 1.8.7, so the travis-ci pull request is ok now. How can merge? M. |
nibalizer
added a commit
that referenced
this pull request
Sep 28, 2015
"Don't autorequire git class"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.