Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests failing in headful

Merged
merged 8 commits into from May 2, 2022
Merged

fix: tests failing in headful #8273

merged 8 commits into from May 2, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 25, 2022

A collection of fixes for the tests failing in headful. There are three failing tests remaining after this PR.

@OrKoN OrKoN changed the title fix: test failing in headful fix: tests failing in headful Apr 25, 2022
@OrKoN OrKoN force-pushed the fix-input-test-in-headful branch 4 times, most recently from 096c7f7 to 9b794ef Compare Apr 29, 2022
@OrKoN OrKoN requested a review from ergunsh Apr 29, 2022
@OrKoN OrKoN force-pushed the fix-input-test-in-headful branch from 9b794ef to a74b4bf Compare Apr 29, 2022
ergunsh
ergunsh approved these changes May 2, 2022
Copy link
Collaborator

@ergunsh ergunsh left a comment

LGTM

src/node/Launcher.ts Show resolved Hide resolved
@OrKoN OrKoN force-pushed the fix-input-test-in-headful branch from a74b4bf to f76b763 Compare May 2, 2022
@OrKoN OrKoN merged commit e841d7f into main May 2, 2022
11 checks passed
@OrKoN OrKoN deleted the fix-input-test-in-headful branch May 2, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants