(PE-36725) Update Aix's pe_repo class name #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
reviewed
Aug 28, 2023
lib/beaker-pe/install/pe_utils.rb
Outdated
| @@ -507,6 +507,8 @@ def deploy_frictionless_to_master(host) | |||
| else | |||
| klass = "pe_repo::platform::windows_x86_64" | |||
| end | |||
| elsif platform == "aix-7.2-power" && !version_is_less(master[:pe_ver], '2022.99.99') | |||
There was a problem hiding this comment.
Should we do a regex like /aix-.*-power/ to avoid this in the future?
There was a problem hiding this comment.
Or, I suppose, if we fix the platform tag we are passing in here, we could avoid this entirely. I guess that's coming from Beaker, which comes from vmpooler, which is named aix-7.2-power. Blargh.
|
Validated this with a frictionless install of latest PE main build, currently validating an upgrade scenario (where we use pe_repo with the old classification of AIX on install, then new classification on upgrade). |
cthorn42
force-pushed
the
maint/main/PE-36725_fix_aix_frictionles
branch
from
c87aff9
to
7e00ba8
Compare
|
Upgrade testing has passed, I think this should be good to go. |
joshcooper
approved these changes
Aug 29, 2023
yachub
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.