(GH-2922) Save unset environment variables #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bolt_env_wrapper` script unsets several environment variables to make Bolt execution predictable. Unsetting these variables also means they are unset when Bolt runs Ruby tasks and scripts over the local transport, which is incidental to Bolt being written in Ruby. The env wrapper now saves Ruby-related environment variables to new `BOLT_ORIG_<env_var>` variables, which allows Bolt to restore the original values when running over the local transport with `bundled-ruby` set to false.
beechtom
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bolt_env_wrapperscript unsets several environment variables tomake Bolt execution predictable. Unsetting these variables also means
they are unset when Bolt runs Ruby tasks and scripts over the local
transport, which is incidental to Bolt being written in Ruby. The env
wrapper now saves Ruby-related environment variables to new
BOLT_ORIG_<env_var>variables, which allows Bolt to restore theoriginal values when running over the local transport with
bundled-rubyset to false.