-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Self-Reference Substitution #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must be checking for non-empty in accordance to line in Java project: https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/SimpleConfigObject.java#L364
The method config_delayed_merge_object::resolve_substitutions must be implemented like here: https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/ConfigDelayedMergeObject.java#L53 Also the class config_delayed_merge_object must inherit from class unmergeable like here: https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/ConfigDelayedMergeObject.java#L21
The method config_delayed_merge_object::resolve_substitutions must be implemented like here: https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/ConfigDelayedMergeObject.java#L53 Also the class config_delayed_merge_object must inherit from class unmergeable like here: https://github.com/lightbend/config/blob/master/config/src/main/java/com/typesafe/config/impl/ConfigDelayedMergeObject.java#L21
Added two tests for nested substitution and assignment.
Fix expected results of tests.
Include definition of class resolve_result
CLA signed by all contributors. |
MikaelSmith
reviewed
May 18, 2018
@@ -112,34 +112,6 @@ static shared_object subst_env_var_object() { | |||
return resolved; | |||
} | |||
|
|||
static shared_object subst_nested_chain_object() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove these tests? Decided they duplicated others?
MikaelSmith
approved these changes
May 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks sane.
Thanks so much for looking into this! |
MikaelSmith
added a commit
to MikaelSmith/cpp-hocon
that referenced
this pull request
May 18, 2018
MikaelSmith
added a commit
to MikaelSmith/cpp-hocon
that referenced
this pull request
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation: https://github.com/lightbend/config/blob/master/HOCON.md#examples-of-self-referential-substitutions
But I'm getting crash in cases below:
Open Issue #105