This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
(FM 7115) return device certificates with task results #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include each target's certificate fingerprint in task results.
tkishel
force-pushed
the
FM-7115_return_cert_with_task_results
branch
from
5d3a721
to
43689f5
Compare
|
Nice fixup, this would benefit greatly from some acceptance tests, to prevent regressions later on. There are example of task testing here https://github.com/puppetlabs/puppetlabs-service/blob/master/spec/acceptance/init_spec.rb or in apache or mysql |
Add puppet device and puppt task tests.
|
Added acceptance tests. |
correct rubocop issues
|
@tkishel i am looking at separating out the device stuff you implemented into its own test. Bit busy today, so apologies for not having it ready sooner. |
|
a commit soon 🤞 |
|
No worries! I was working on this in parallel. Let me know if the latest commit is 'too big'. |
Refactor acceptance tests. Move acceptance 'run' tests out of configure_spec.rb. Test the fingerprint in the run task results.
Make '--user=root' conditional in the task, to match the Puppet code.
tkishel
force-pushed
the
FM-7115_return_cert_with_task_results
branch
from
ced4738
to
f823bac
Compare
|
small rubocop fix. also can you rename the acceptance task test, to indicate it is a task test |
Rename the acceptance task test, to indicate it is a task test. Use Puppet::SSL::Host.new.suitable_message_digest_algorithms rather than hardcode. Rubocop fix.
|
Done! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(FM-7115) return device certificates with task results
Include each target's certificate fingerprint in task results.