This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Do not require aio_agent_version to be present #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started in PR #41 but one more check was left behind in device_manager::devices
I don't even think it's an enterprise/non-enterprise distinction. It looks like packaging differences:
When facter is built as part of the puppet-agent package, as it does in the puppetlabs yum repo, it gets the agent version fact compiled in from the config variable. Hence, I suspect, the aio (all-in-one) prefix.
If facter lives in a separate package, as it does in Arch official repos, it can't have the fact compiled in, as the agent version can change independently. At least this is the way I understand it.
As an Arch user, this is the second puppet module where I run into problems with missing aio_agent_version.