(FACT-2481) Fix caching

[BogdanIrimie]

No description provided.

[Filipovici-Andrei]

I think we are going in the wrong direction with the @fact_list and @semaphore. They shouldn't be tampered with in the resolvers. They should exist only in the BaseResolver. BaseResolver should be like a template, for what resolvers should do, and each resolver would implement just the post_resolve method. Caching, logging and synchronising should be dealt with in just ONE PLACE, in the BaseResolver.

[Filipovici-Andrei]

In other resolvers you have @fact_list ||= {}

[BogdanIrimie]

As @fact_list is initialise on class creation, there is no need for ||=

[Filipovici-Andrei]

In other resolvers you have @fact_list ||= {}

[BogdanIrimie]

As @fact_list is initialise on class creation, there is no need for ||=

[gimmyxd]

should this be @fact_list = {} as in other resolvers?

[BogdanIrimie]

Yes

[BogdanIrimie]

@Filipovici-Andrei @semaphore serialize access to one resolver, it should be declared and used at a resolver level, otherwise it would serialize access to all resolvers! Caching is done at the resolver level and should be kept at this level because serialisation is done at this level. The logger can be moved to base resolver.