This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
(maint) Fix trace acceptance test #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
force-pushed
the
fix_acceptance
branch
from
383b2a0
to
241dcc0
Compare
BogdanIrimie
previously approved these changes
Mar 24, 2020
oanatmaria
force-pushed
the
fix_acceptance
branch
from
241dcc0
to
95aaf60
Compare
sebastian-miclea
previously approved these changes
Mar 24, 2020
gimmyxd
reviewed
Mar 24, 2020
gimmyxd
reviewed
Mar 25, 2020
lib/facter.rb
Outdated
| @@ -202,6 +203,7 @@ def to_hash | |||
| # @api public | |||
| def trace? | |||
| LegacyFacter.trace? | |||
There was a problem hiding this comment.
is this call needed anymore?
| @@ -212,6 +214,7 @@ def trace? | |||
| # @api public | |||
| def trace(bool) | |||
| LegacyFacter.trace(bool) | |||
There was a problem hiding this comment.
is this call needed anymore?
There was a problem hiding this comment.
LegacyFacter.log_exception is still used in other classes like collection.rb, so setting trace in LegacyFacter is still needed.
oanatmaria
force-pushed
the
fix_acceptance
branch
2 times, most recently
from
d9f85e2
to
c8dfde8
Compare
oanatmaria
force-pushed
the
fix_acceptance
branch
from
c8dfde8
to
0381e5d
Compare
gimmyxd
reviewed
Mar 25, 2020
spec/facter/facter_spec.rb
Outdated
| describe '#log_exception' do | ||
| context 'when trace options is true' do | ||
| before do | ||
| Facter.instance_variable_set(:@trace, true) |
There was a problem hiding this comment.
why not set it using Facter.trace method?
There was a problem hiding this comment.
also i think it should be set to false, after running the test
oanatmaria
force-pushed
the
fix_acceptance
branch
from
0381e5d
to
3b935d7
Compare
BogdanIrimie
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.