This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Avoid exceptions for zone facts on FreeBSD #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
improve-solaris-facts-failure-resilience
branch
from
4fb3469
to
3ba06cc
Compare
|
Please note that this PR is not enough to run Facter 4 on FreeBSD: I try to isolate each issue and handle them independently. Thanks! |
smortex
force-pushed
the
improve-solaris-facts-failure-resilience
branch
2 times, most recently
from
26798cb
to
c4a8b3a
Compare
|
@smortex Thank you for the PR. I made an experimental error handling mechanism that would help us in identifying quickly all the errors https://github.com/puppetlabs/facter-ng/tree/experimental_error_handling_for_facts please give it a try. |
|
@IrimieBogdan nice! When running your branch without my patch, I get: When I merge my branch, these errors are not reported anymore. Thanks! |
|
Rubocop does not report any error when running on my system. Is it possible to have the CI report the "2 new offenses" detected to fix them? |
|
Sure, you can remove the files that you have changed from https://github.com/puppetlabs/facter-ng/blob/master/.rubocop_todo.yml and rubocop will report the errors in those files. |
FreeBSD currently loads all Solaris facts, but FreeBSD does not have "zones", and the zone related facts fail hardly when being processed. Improve error detection when building the zone facts, and do not emit these facts when an error occurred.
smortex
force-pushed
the
improve-solaris-facts-failure-resilience
branch
from
c4a8b3a
to
aa60dcc
Compare
BogdanIrimie
approved these changes
Mar 26, 2020
|
@smortex excellent job with this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD currently loads all Solaris facts, but FreeBSD does not have "zones", and the zone related facts fail hardly when being processed.
Improve error detection when building the zone facts, and do not emit these facts when an error occurred.
This fixes the following errors: